Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update --rpc-cache.headers name #14336

Merged
merged 1 commit into from
Feb 8, 2025
Merged

fix: update --rpc-cache.headers name #14336

merged 1 commit into from
Feb 8, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 8, 2025

this should be headers.

kept -env as alias for backwards compat

@mattsse mattsse added A-cli Related to the reth CLI A-rpc Related to the RPC implementation labels Feb 8, 2025
@mattsse mattsse enabled auto-merge February 8, 2025 16:26
@mattsse mattsse added this pull request to the merge queue Feb 8, 2025
Merged via the queue into main with commit 2b16b06 Feb 8, 2025
45 checks passed
@mattsse mattsse deleted the matt/update-cache-env-arg branch February 8, 2025 16:45
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@mattsse @18aaddy
fix: update --rpc-cache.headers name (paradigmxyz#14336)
91bd05d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes