fix(isthmus): include storage updates in l2 withdrawals root computation #14307
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-bug
emhane
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
reviewed
Feb 7, 2025
There was a problem hiding this comment.
this seems right, but would like another review from
@shekhirin or @rkrasiuk
This was referenced Feb 13, 2025
rkrasiuk
approved these changes
Feb 14, 2025
Comment on lines
+393
to
+396
| Some(state.database.as_ref().storage_root( | ||
| ADDRESS_L2_TO_L1_MESSAGE_PASSER, | ||
| hashed_storage_updates.unwrap_or_default(), | ||
| )?) |
There was a problem hiding this comment.
this most likely does redundant IO because we might traverse this path during state root computation. please, leave a comment saying this. the proper way would be to include state_root in the MultiProof struct and call state_provider.multiproof with the target instead of state_provider.root when sealing a block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.