Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm todo #14289

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: rm todo #14289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions crates/stages/api/src/pipeline/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,7 @@ impl<N: ProviderNodeTypes> Pipeline<N> {
/// pipeline and its result as a future.
#[track_caller]
pub fn run_as_fut(mut self, target: Option<PipelineTarget>) -> PipelineFut<N> {
// TODO: fix this in a follow up PR. ideally, consensus engine would be responsible for
// updating metrics.
let _ = self.register_metrics(); // ignore error
let _ = self.register_metrics();
Box::pin(async move {
// NOTE: the tip should only be None if we are in continuous sync mode.
if let Some(target) = target {
Expand Down
Loading