test: add a test for devnet failure #14288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/reorg-backfill-test
branch
from
4c56202 to
d6df51a
Compare
mattsse
requested review from
onbjerg,
rkrasiuk,
mattsse and
Rjected
as code owners
mattsse
added
C-bug
|
The bug here is that we never reset the headers downloader, becase the unwind, we still have the same sync target, which would normally reset it. the fix here is to clear the trackers when we encounter the error |
mattsse
removed
the
S-blocked
mattsse
approved these changes
Feb 8, 2025
18aaddy
pushed a commit
to 18aaddy/reth
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test reproducing bug we've occured on devnet.
The bug here was that we never reset the internal request pointers if the sync target hasn't changed.
The fix here is to always start by redownloading the tip, resetting the pointers
although still need to verify this
reth/crates/stages/stages/src/stages/headers.rs
Lines 245 to 246 in 7118abe