Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: record save_cache duration metrics #14281

Merged
merged 1 commit into from
Feb 7, 2025
Merged

feat: record save_cache duration metrics #14281

merged 1 commit into from
Feb 7, 2025

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Feb 6, 2025

Now that we have caching, we can use this metric

@Rjected Rjected added C-perf A change motivated by improving speed, memory usage or disk footprint A-observability Related to tracing, metrics, logs and other observability tools labels Feb 6, 2025
@Rjected Rjected added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit da86ff3 Feb 7, 2025
45 checks passed
@Rjected Rjected deleted the dan/record-save-cache-duration-metric branch February 7, 2025 18:08
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@Rjected @18aaddy
feat: record save_cache duration metrics (paradigmxyz#14281)
8faf177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @fgimenez