Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify PayloadBuilder setup #14276

Merged
merged 7 commits into from
Feb 6, 2025
Merged

feat: simplify PayloadBuilder setup #14276

merged 7 commits into from
Feb 6, 2025

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Feb 6, 2025

Closes #14255

Moves payload job generator setup into EngineNodeLauncher, only requiring node to build the actual PayloadBuilder

@github-actions github-actions bot added A-sdk Related to reth's use as a library C-enhancement New feature or request labels Feb 6, 2025
mattsse
mattsse approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot nicer,

we do lock in the job generator part, but I think this we can address

but let's delay until we know how

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Feb 6, 2025
mattsse
mattsse approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this is even better, this now provides the default builder service as the default trait impl with the option to override it

crates/node/builder/src/components/builder.rs
Node,
PayloadBuilder = PayloadBuilderHandle<<Node::Types as NodeTypesWithEngine>::Engine>,
>;
type Components: NodeComponents<Node>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot nicer

@klkvr klkvr enabled auto-merge February 6, 2025 20:36
@klkvr klkvr added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 1f1eabc Feb 6, 2025
44 checks passed
@klkvr klkvr deleted the klkvr/rm-payload-builder-handle-traits branch February 6, 2025 20:56
@klkvr klkvr mentioned this pull request Feb 8, 2025
Merged
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@klkvr @18aaddy
feat: simplify PayloadBuilder setup (paradigmxyz#14276)
8cfcbd8
@hai-rise hai-rise mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to access configured PayloadBuilder
2 participants
@klkvr @mattsse