feat: abstract EthTransactionValidator over ChainSpec
#14162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 3, 2025
Comment on lines
+46
to
+47
| #[derive(Debug)] | ||
| pub struct MockEthProvider<T = TransactionSigned, ChainSpec = reth_chainspec::ChainSpec> { |
There was a problem hiding this comment.
perhaps we even make this one generic over NodeTypes, but we should make this a good first issue
| .kzg_settings(self.kzg_settings()?) | ||
| .with_additional_tasks(1) | ||
| .build_with_tasks( | ||
| blockchain_db.clone(), |
There was a problem hiding this comment.
ah yeah this was kinda redundant
klkvr
force-pushed
the
klkvr/abstract-pool-over-chainspec
branch
from
dcd323f to
64aa8ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing concrete ethereum ChainSpec, makes validator to access it as
Client::ChainSpecthus allowing to not depend on any concrete type.