Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename variables and fix typos in tables.rs, execution.rs, and mdbx code #14148

Merged
merged 7 commits into from
Feb 3, 2025
Merged

fix: rename variables and fix typos in tables.rs, execution.rs, and mdbx code #14148

merged 7 commits into from
Feb 3, 2025

Conversation

MarsonKotovi4
Copy link
Contributor

  • Changed strat_values to start_values and strat_keys to start_keys in tables.rs for clarity.
  • Tweaked a few comments in execution.rs to correct grammar.
  • Fixed typos in mdbx.c and mdbx.h (e.g., “readed” → “read”).
  • No functional changes, just minor cleanups to improve readability.

mattsse
mattsse requested changes Feb 1, 2025
View reviewed changes
crates/storage/libmdbx-rs/mdbx-sys/libmdbx/mdbx.c Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this I file I dont want to change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

crates/storage/libmdbx-rs/mdbx-sys/libmdbx/mdbx.h Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. fixed

@MarsonKotovi4
Copy link
Contributor Author

@mattsse pls check

@MarsonKotovi4 MarsonKotovi4 requested a review from mattsse February 2, 2025 13:34
@mattsse mattsse added the C-docs An addition or correction to our documentation label Feb 3, 2025
@mattsse mattsse enabled auto-merge February 3, 2025 09:58
@mattsse mattsse added this pull request to the merge queue Feb 3, 2025
Merged via the queue into paradigmxyz:main with commit 0ad7de4 Feb 3, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarsonKotovi4 @mattsse