Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hive): overflow when timestamp is u64::max #14132

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix(hive): overflow when timestamp is u64::max #14132

merged 1 commit into from
Jan 31, 2025

Conversation

joshieDo
Copy link
Collaborator

Some tests have a u64::max timestamp, and we'd overflow there

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior C-hivetest Used for labelling automated issues relating to hive test failures A-ci Related to github workflows or other build and lint tools labels Jan 31, 2025
@joshieDo joshieDo enabled auto-merge January 31, 2025 20:22
Rjected
Rjected approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshieDo joshieDo added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit d30a1b6 Jan 31, 2025
45 checks passed
@joshieDo joshieDo deleted the joshie/sat12 branch January 31, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools C-bug An unexpected or incorrect behavior C-hivetest Used for labelling automated issues relating to hive test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @Rjected