Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): update pending block on InsertExecutedBlock #14098

Merged
merged 1 commit into from
Jan 30, 2025
Merged

feat(engine): update pending block on InsertExecutedBlock #14098

merged 1 commit into from
Jan 30, 2025

Conversation

rkrasiuk
Copy link
Member

Description

Update pending block on EngineApiRequest::InsertExecutedBlock request.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-consensus Related to the consensus engine labels Jan 30, 2025
mattsse
mattsse approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lgtm

@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 6b13409 Jan 30, 2025
45 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/update-pending-on-insert-executed branch January 30, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse