feat: abstract over Evm::Error

[klkvr]

Changes in this PR:

• Evm::Error is no longer bounded to a concrete type (was EVMError<DB::Error> before). Instead, EvmError trait is introduced:

  reth/crates/evm/src/lib.rs

  Lines 98 to 113 in b1dfab9

  	/// Abstraction over errors that can occur during EVM execution.
  	///
  	/// Assumed that errors can occur either because of an invalid transaction, meaning that other
  	/// transaction might still result in successful execution, or because of a general EVM
  	/// misconfiguration.
  	///
  	/// If caller occurs a error different from [`EvmError::InvalidTransaction`], it should most likely
  	/// be treated as fatal error flagging some EVM misconfiguration.
  	pub trait EvmError: core::error::Error + Send + Sync + 'static {
  	/// Errors which might occur as a result of an invalid transaction. i.e unrelated to general EVM
  	/// configuration.
  	type InvalidTransaction: InvalidTxError;
  	/// Returns the [`InvalidTransactionError`] if the error is an invalid transaction error.
  	fn as_invalid_tx_err(&self) -> Option<&Self::InvalidTransaction>;
  	}

• Current revm does not yet have core::error::Error bound on Database::Error, so I've introduced a helper Database trait which is now used everywhere:

  reth/crates/evm/src/lib.rs

  Lines 129 to 131 in b1dfab9

  	/// Helper trait to bound [`revm::Database::Error`] with common requirements.
  	pub trait Database: revm::Database<Error: core::error::Error + Send + Sync + 'static> {}
  	impl<T> Database for T where T: revm::Database<Error: core::error::Error + Send + Sync + 'static> {}

  
  This is not great and won't get solved with new revm because it doesn't have Send + Sync + 'static bounds. What we could do is just bound Error = ProviderError everywhere but this would also be a bit redundant.
• On RPC side, EthApi::Error is now required to implement From<EthApi::Evm::EvmError<ProviderError>> which basically means that it should be able to convert any Evm error as long as underlying database has ProviderError error type which always holds for RPC.
  

  reth/crates/rpc/rpc-eth-types/src/error/api.rs

  Lines 82 to 89 in 3b6d97e

  	/// Helper trait to convert from revm errors.
  	pub trait FromEvmError<Evm: ConfigureEvm>: From<Evm::EvmError<ProviderError>> {
  	/// Converts from EVM error to this type.
  	fn from_evm_err(err: Evm::EvmError<ProviderError>) -> Self {
  	err.into()
  	}
  	}

[mattsse]

this is great, this should open up a few more things once we've migrated to new revm

smol nits

[mattsse]

so much butter indeed

[mattsse]

this is great