Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make impls for MockEthProvider more generic #14055

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Make impls for MockEthProvider more generic #14055

merged 3 commits into from
Jan 29, 2025

Conversation

yohkaz
Copy link
Contributor

@yohkaz yohkaz commented Jan 28, 2025

(potentially) Closes #14038

emhane
emhane approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@emhane emhane enabled auto-merge January 28, 2025 23:26
@emhane emhane added this pull request to the merge queue Jan 29, 2025
Merged via the queue into paradigmxyz:main with commit a4b4088 Jan 29, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane emhane approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalise impls for MockEthProvider
3 participants
@yohkaz @mattsse @emhane