Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm optimism feature from reth-provider #14035

Merged
merged 4 commits into from
Jan 28, 2025
Merged

chore: rm optimism feature from reth-provider #14035

merged 4 commits into from
Jan 28, 2025
+19 −34

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 28, 2025

we only have this for the op mainnet consistency check

we have this somewhere else as well:

reth/crates/node/builder/src/launch/common.rs

Lines 793 to 796 in 0d58576

if self.chain_spec().is_optimism() &&
!self.is_dev() &&
self.chain_id() == Chain::optimism_mainnet()
{

which doesn't need features because the chainspec has an is_optimism fn

this removes the feature and changes the ovm block lookup slightly

@mattsse mattsse added C-debt A clean up/refactor of existing code A-op-reth Related to Optimism and op-reth labels Jan 28, 2025
@mattsse mattsse requested a review from joshieDo January 28, 2025 13:09
@mattsse mattsse enabled auto-merge January 28, 2025 13:12
@mattsse mattsse added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 5cf0276 Jan 28, 2025
44 checks passed
@mattsse mattsse deleted the matt/rm-op-feature branch January 28, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @joshieDo