Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Events generic from RPC types #14033

Merged
merged 2 commits into from
Jan 28, 2025
Merged

refactor: remove Events generic from RPC types #14033

merged 2 commits into from
Jan 28, 2025

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Jan 28, 2025

Provider implements the CanonStateSubscriptions and always used in place of Events generic.

This PR removes it and just relies on Provider instead

@klkvr klkvr added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jan 28, 2025
mattsse
mattsse approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better,

this generic predates some internal changes and is now obsolete, imo it is sound that the provider type is responsible for providing the events

@mattsse mattsse added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 0f2e2fa Jan 28, 2025
44 checks passed
@mattsse mattsse deleted the klkvr/rm-events-rpc-builder branch January 28, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse