Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove executed_block from EthBuiltPayload #14017

Merged
merged 2 commits into from
Jan 27, 2025
Merged

chore: remove executed_block from EthBuiltPayload #14017

merged 2 commits into from
Jan 27, 2025

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 27, 2025

This field is only really useful for op, since reinsertion into the tree is much more valuable due to how OP works, so this is removed from the EthBuiltPayload struct

@Rjected Rjected added C-enhancement New feature or request A-block-building Related to block building labels Jan 27, 2025
@Rjected Rjected requested a review from mattsse as a code owner January 27, 2025 19:14
@Rjected Rjected force-pushed the dan/remove-executed-block-ethbuiltpayload branch from c027f33 to 0011a6a Compare January 27, 2025 19:28
@Rjected Rjected requested a review from gakonst as a code owner January 27, 2025 19:28
@Rjected Rjected force-pushed the dan/remove-executed-block-ethbuiltpayload branch from 0011a6a to c642e43 Compare January 27, 2025 19:35
mattsse
mattsse approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change,

for ethereum this feature is very pointless and would only benefit vanilla reth builders and the benefit is only: don't execute your own block, so not worth keeping

@mattsse mattsse added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit ddc9375 Jan 27, 2025
43 checks passed
@mattsse mattsse deleted the dan/remove-executed-block-ethbuiltpayload branch January 27, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse