Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: do not clone recovered block #14016

Merged
merged 1 commit into from
Jan 27, 2025
Merged

perf: do not clone recovered block #14016

merged 1 commit into from
Jan 27, 2025

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 27, 2025

No description provided.

@Rjected Rjected added C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint labels Jan 27, 2025
@joshieDo
Copy link
Collaborator

joshieDo commented Jan 27, 2025 •
edited
Loading

The sealed_block doesn't seem to need cloning as well, am i wrong

nvm

@Rjected Rjected added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 2e34fe1 Jan 27, 2025
44 checks passed
@Rjected Rjected deleted the dan/dont-clone-recovered-block branch January 27, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo joshieDo approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @joshieDo @mattsse