Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changed visibility of Cli struct attributes to pub for op-reth #13985

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

cakevm
Copy link
Contributor

@cakevm cakevm commented Jan 25, 2025

As described and already merged in #12074, it is beneficial in an ExEx-context to be able to access the CLI parameters. To enable this, this PR changes the visibility of the op-reth CLI struct attributes to pub, aligning with the existing Cli struct in reth.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be public, yes

ty

@mattsse mattsse enabled auto-merge January 25, 2025 10:09
@mattsse mattsse added the A-cli Related to the reth CLI label Jan 25, 2025
@mattsse mattsse added this pull request to the merge queue Jan 25, 2025
Merged via the queue into paradigmxyz:main with commit 280b6bf Jan 25, 2025
44 checks passed
@cakevm cakevm deleted the op-reth-cli-pub branch January 25, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants