-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reexport bytes & bump version to 1.4 #1395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't remember if it was 1.3 or 1.4 that caused regression of the benchmarking job, IIRC it was 1.3 and we rolled back the cargo.lock bump.
let's see
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1395 +/- ##
==========================================
- Coverage 76.51% 76.51% -0.01%
==========================================
Files 354 354
Lines 40022 40192 +170
==========================================
+ Hits 30623 30751 +128
- Misses 9399 9441 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I don't have any attachments to v1.4, I am fine to temporarily downgrade to v1.2 if there is a problem |
@rakita tried pinning revm to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supportive, let's actually open an issue on Bytes upstream so that it's tracked.
This PR reexports
bytes
crate fromreth-primitives
crate and minimizes the number of instances of direct dependencies onbytes
crate.Why
bytes
crate version was upgraded to1.4
?BytesMut::freeze
(Avoid large reallocations when freezing BytesMut tokio-rs/bytes#592)Why is
bytes
reexport needed?Why
bytes
dependency remained in some crates?reth-primitives
(rpc/ipc
,rlp
)main_codec
(includingreth-primitives
) which generates the code withbytes::Buf
importreth/crates/storage/codecs/derive/src/compact/flags.rs
Lines 50 to 53 in 94674f9
I've attempted generating a dynamic import path with proc-macro-crate, but it failed to cover all usages
NOTE: Possible merge conflicts with #1393