Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: do not clone already recovered block #13944

Merged
merged 1 commit into from
Jan 23, 2025
Merged

chore: do not clone already recovered block #13944

merged 1 commit into from
Jan 23, 2025

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 23, 2025

We already have the recovered block, so we can just Arc it instead of cloning the senders and the sealed block

@Rjected Rjected added C-enhancement New feature or request A-engine Related to the engine implementation labels Jan 23, 2025
mattsse
mattsse approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we have a few more of those since the recent refactor

@mattsse mattsse added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 5a40c68 Jan 23, 2025
44 checks passed
@mattsse mattsse deleted the dan/reuse-block branch January 23, 2025 16:18
refcell pushed a commit to ethereum-optimism/op-reth that referenced this pull request Jan 24, 2025
@Rjected @refcell
chore: do not clone already recovered block (paradigmxyz#13944)
6b0dd23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-engine Related to the engine implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse