Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NetworkManager::eth #13936

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: add NetworkManager::eth #13936

merged 2 commits into from
Jan 22, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 22, 2025

adds a new eth constructor fn so we dont need the eth type hints

Rjected
Rjected approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse enabled auto-merge January 22, 2025 22:51
@mattsse mattsse added the A-networking Related to networking in general label Jan 22, 2025
@mattsse mattsse added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 4dcc135 Jan 22, 2025
43 checks passed
@mattsse mattsse deleted the matt/add-eth-constructor-for-network2 branch January 22, 2025 23:27
refcell pushed a commit to ethereum-optimism/op-reth that referenced this pull request Jan 24, 2025
@mattsse @refcell
feat: add NetworkManager::eth (paradigmxyz#13936)
55af8de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected