Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Exclude reth-payload-builder from wasm check #13932

Merged
merged 2 commits into from
Jan 22, 2025
Merged

chore(ci): Exclude reth-payload-builder from wasm check #13932

merged 2 commits into from
Jan 22, 2025

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 22, 2025

reth-payload-builder depends on reth-metrics, which in turn depends on metrics-derive which is no_std incompatible

@emhane emhane added A-dependencies Pull requests or issues that are about dependencies A-ci Related to github workflows or other build and lint tools labels Jan 22, 2025
@emhane emhane enabled auto-merge January 22, 2025 18:14
@emhane emhane force-pushed the emhane/no-std-payload-builder branch from fc3c803 to b1782ad Compare January 22, 2025 18:14
@emhane emhane added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 3b0e70a Jan 22, 2025
45 checks passed
@emhane emhane deleted the emhane/no-std-payload-builder branch January 22, 2025 20:35
refcell pushed a commit to ethereum-optimism/op-reth that referenced this pull request Jan 24, 2025
@emhane @refcell
chore(ci): Exclude reth-payload-builder from wasm check (paradigmxy…
85123d2 
…z#13932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse