chore: move and integrate ConfigureEvmFor #13896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Rjected
requested review from
mattsse,
fgimenez,
onbjerg,
klkvr,
rakita,
rkrasiuk and
gakonst
as code owners
Rjected
force-pushed
the
dan/use-configure-evm-for
branch
2 times, most recently
from
9e9ed92 to
84e837c
Compare
mattsse
approved these changes
Jan 21, 2025
| @@ -43,7 +43,7 @@ pub trait NodeComponents<T: FullNodeTypes>: Clone + Unpin + Send + Sync + 'stati | |||
| type Pool: TransactionPool<Transaction: PoolTransaction<Consensus = TxTy<T::Types>>> + Unpin; | |||
|
|
|||
| /// The node's EVM configuration, defining settings for the Ethereum Virtual Machine. | |||
| type Evm: ConfigureEvm<Header = HeaderTy<T::Types>, Transaction = TxTy<T::Types>>; | |||
| type Evm: ConfigureEvmFor<<T::Types as NodeTypes>::Primitives>; | |||
There was a problem hiding this comment.
we could also introduce an alias for this PrimitivesFor for example
Rjected
force-pushed
the
dan/use-configure-evm-for
branch
from
84e837c to
a0df055
Compare
refcell
pushed a commit
to ethereum-optimism/op-reth
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trait was actually not in a place where it could be used properly (it would have caused cyclic deps), it's now moved to
reth_evmwhere theConfigureEvmtrait actually is. the evm crate also imports primitives-traits, so we can define it there for no extra deps onConfigureEvmconsumers. Node-builder only really makes sense when we need to connect e.g. reth-provider and network.