Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move state root task result handling to fn #13892

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 20, 2025

Similar to #13888 but moves the state root task result handling logic to a separate fn

@Rjected Rjected added C-enhancement New feature or request A-engine Related to the engine implementation A-trie Related to Merkle Patricia Trie implementation labels Jan 20, 2025
@Rjected Rjected force-pushed the dan/state-root-task-result-handling-fn branch from 90d4239 to 7fb4129 Compare January 20, 2025 22:30
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 21, 2025
@rkrasiuk rkrasiuk removed this pull request from the merge queue due to a manual request Jan 21, 2025
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
@rkrasiuk rkrasiuk enabled auto-merge January 21, 2025 11:38
@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit c4b147c Jan 21, 2025
43 checks passed
@rkrasiuk rkrasiuk deleted the dan/state-root-task-result-handling-fn branch January 21, 2025 12:08
refcell pushed a commit to ethereum-optimism/op-reth that referenced this pull request Jan 24, 2025
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-engine Related to the engine implementation A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants