feat: use reth-ethereum-primitives
#13830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
approved these changes
Jan 16, 2025
| @@ -356,7 +356,7 @@ mod test { | |||
| #[test] | |||
| fn eth68_announcement_unrecognized_tx_type() { | |||
| let types = vec
mattsse
approved these changes
Jan 17, 2025
| assert_eq!(tx_type_result, expected) | ||
| } | ||
| } | ||
| pub use alloy_consensus::TxType; |
|
merging this because this pr is a conflict magnet |
|
second hell yeah |
|
third hell yeah, nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes primitive types declared in in reth-primitives in favor of the same types from reth-ethereum-primitives which are just re-exported for now.
optimismfeature is removed from reth-primitives as wellWith this PR, the only optimism-gated logic in primitive types crates is this one directly related to revm
reth/crates/optimism/primitives/src/transaction/signed.rs
Lines 127 to 128 in 1922b79