fix(tree): use in memory trie cursor for trie updates comparison in tree #13789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-bug
…tes-in-memory-cursor
…tes-in-memory-cursor
shekhirin
requested review from
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
shekhirin
force-pushed
the
alexey/tree-trie-updates-in-memory-cursor
branch
from
342de79 to
bb938c3
Compare
shekhirin
requested review from
joshieDo,
rakita,
onbjerg,
klkvr and
gakonst
as code owners
shekhirin
force-pushed
the
alexey/tree-trie-updates-in-memory-cursor
branch
from
bb938c3 to
c97cc2f
Compare
This reverts commit c97cc2f.
rkrasiuk
approved these changes
Jan 14, 2025
klkvr
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should compare trie updates against the in-memory state + database state.