refactor: reduce Hardforks trait usage
#13728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
rkrasiuk,
onbjerg,
joshieDo and
gakonst
as code owners
mattsse
approved these changes
Jan 8, 2025
| @@ -209,12 +209,10 @@ where | |||
| fn validate_header_with_total_difficulty( | |||
| &self, | |||
| header: &H, | |||
| total_difficulty: U256, | |||
| _total_difficulty: U256, | |||
There was a problem hiding this comment.
looks like we can technically drop this arg, but makes sense to keep I guess
There was a problem hiding this comment.
yeah we should probably just merge logic from this fn into validate_header at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
Hardforkssupertrait forEthereumHardforksandOpHardforks. We're going to move those traits to a standalone evm repo and I'd prefer to not movedyn Hardforkstuff there.We still need
Hardforkstrait for EIP-6122 implementation and in some other places where we don't yet operate purely on network-specific hardfork traits