Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SparseStateTrie::reveal_witness #13719

Merged
merged 3 commits into from
Jan 8, 2025
Merged

feat: SparseStateTrie::reveal_witness #13719

merged 3 commits into from
Jan 8, 2025

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Jan 8, 2025

Description

Implements SparseStateTrie::reveal_witness capable of revealing trie nodes from state witness.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-trie Related to Merkle Patricia Trie implementation labels Jan 8, 2025
shekhirin
shekhirin approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, LGTM. Only one comment on as_hash usage.

@rkrasiuk rkrasiuk enabled auto-merge January 8, 2025 10:05
@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 91fef29 Jan 8, 2025
43 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/sparse-reveal-witness branch January 8, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @shekhirin