feat(engine): add StateRootTask skeleton #12305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
rkrasiuk,
mattsse,
Rjected and
gakonst
as code owners
rkrasiuk
approved these changes
Nov 4, 2024
crates/engine/tree/src/tree/root.rs
Outdated
Comment on lines
31
to
32
| /// Current state. | ||
| state: HashedPostState, |
There was a problem hiding this comment.
with sparse trie there won't be a need for this field
There was a problem hiding this comment.
ok removed here b3b9651 thx!
fgimenez
added
C-enhancement
gakonst
reviewed
Nov 4, 2024
Comment on lines
+25
to
+26
| /// View over the state in the database. | ||
| consistent_view: ConsistentDbView<Factory>, |
There was a problem hiding this comment.
Is this still something we want to retain in our new designs? I thought the consistent db viewer was a 'hack' and we were looking for ways to do this better? Maybe I misremember
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #12053