feature: transaction's input truncate function #12236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nadtech-hub <taberlick@gmail.com>
mattsse
requested changes
Nov 1, 2024
| @@ -102,7 +102,9 @@ impl TransactionCompat for () { | |||
| WithOtherFields::default() | |||
| } | |||
|
|
|||
| fn otterscan_api_truncate_input(_tx: &mut Self::Transaction) {} | |||
| fn otterscan_api_truncate_input(tx: &mut Self::Transaction) { | |||
| tx.input = tx.input.slice(..4); | |||
There was a problem hiding this comment.
this is actually dangerous and incorrect in the other implementations as well, we need to check that the input slice actually as at least 4 items
There was a problem hiding this comment.
it is double-check in case of otterscan. input may contain arbitrary data so truncating will return smth nonse
There was a problem hiding this comment.
I see, but this check should be in the impl instead, can do that separately, though
mattsse
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should close 11163