replace DisplayHardforks with Box<dyn Display> #12219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
mattsse,
Rjected,
fgimenez,
emhane and
joshieDo
as code owners
joshieDo
reviewed
Oct 31, 2024
crates/chainspec/src/api.rs
Outdated
| fn display_hardforks(&self) -> DisplayHardforks { | ||
| self.display_hardforks() | ||
| fn display_hardforks(&self) -> Box<dyn Display> { | ||
| Box::new(self.display_hardforks()) |
There was a problem hiding this comment.
Suggested change
| Box::new(self.display_hardforks()) | |
| self.display_hardforks().boxed() |
There was a problem hiding this comment.
There is no method named boxed for struct Box<(dyn derive_more::Display + 'static)>.
Let me know if I should add something like pub fn boxed(self) -> Box<dyn Hardfork> { Box::new(self) } somewhere.
There was a problem hiding this comment.
ChainSpec::display_forks (not the trait impl) could still return the type DisplayHardforks which would have a boxed method called here
mattsse
approved these changes
Oct 31, 2024
mattsse
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12208