Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): use NodeTypes on DatabaseProvider instead #12166

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat(provider): use NodeTypes on DatabaseProvider instead #12166

merged 1 commit into from
Oct 29, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Oct 29, 2024 •
edited
Loading

With both #12157 and #11872 requiring new NodePrimitives associated types as generics in DatabaseProvider, it makes sense to have it accept NodePrimitives instead

reth/crates/storage/provider/src/providers/database/provider.rs

Line 130 in b63e036

pub struct DatabaseProvider<TX, N: NodeTypes> {

@joshieDo joshieDo added C-enhancement New feature or request A-db Related to the database A-sdk Related to reth's use as a library labels Oct 29, 2024
@joshieDo joshieDo requested a review from mattsse October 29, 2024 14:16
@joshieDo joshieDo changed the title feat(provider): use NodeTypes on DatabaseProvider feat(provider): use NodeTypes on DatabaseProvider instead Oct 29, 2024
mattsse
mattsse approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this way we get access to all primitives which is what we need

@joshieDo joshieDo added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 1006ce7 Oct 29, 2024
40 checks passed
@joshieDo joshieDo deleted the joshie/dbn branch October 29, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse