Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(provider): remove unused BlockExecutionReader trait #12156

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore(provider): remove unused BlockExecutionReader trait #12156

merged 1 commit into from
Oct 29, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Oct 29, 2024 •
edited
Loading

Also removes DatabaseProvider::get_block_range and DatabaseProvider::get_block_transaction_range

@joshieDo joshieDo added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Oct 29, 2024
mattsse
mattsse approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@joshieDo joshieDo added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 2dbbd15 Oct 29, 2024
40 checks passed
@joshieDo joshieDo deleted the joshie/unused branch October 29, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse