Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): remove redundant LoadFee::cache #12146

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore(rpc): remove redundant LoadFee::cache #12146

merged 1 commit into from
Oct 28, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 28, 2024

Removes trait method LoadFee::cache, cache getter is already inherited from LoadBlock

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library labels Oct 28, 2024
@emhane emhane enabled auto-merge October 28, 2024 16:28
@emhane emhane force-pushed the emhane/rm-cache-getter-load-fee branch from 4761bb1 to d94155b Compare October 28, 2024 16:36
@emhane emhane requested a review from fgimenez as a code owner October 28, 2024 16:36
@emhane emhane added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 473026f Oct 28, 2024
40 checks passed
@emhane emhane deleted the emhane/rm-cache-getter-load-fee branch October 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse