dev: track invalid transactions by sender in pool #12138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 28, 2024
Comment on lines
99
to
104
| // Mark all descendants as invalid | ||
| let mut descendant_id = tx.id().descendant(); | ||
| while let Some(descendant) = self.all.get(&descendant_id) { | ||
| self.invalid.insert(*descendant.transaction.hash()); | ||
| descendant_id = descendant.transaction.id().descendant(); | ||
| } |
There was a problem hiding this comment.
we kinda already have an euqivalent check for this in next, so what we actually need to check instead is marking the SenderId as self.invalid and not the hash. so instead of self.invalid.insert(*tx.hash()); we need to track the tx.sender_id instead
There was a problem hiding this comment.
sorry I misunderstood the issue, getting on it
mattsse
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the tracking of invalid transactions in the pool by tracking them by sender id instead of transaction hash.
Resolves #12136