feat: Add version to BeaconEngineMessage FCU
#12089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 26, 2024
Comment on lines
328
to
337
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use crate::OpPayloadAttributes; | ||
| use alloy_primitives::{address, b256, bytes, FixedBytes}; | ||
| use alloy_rpc_types_engine::PayloadAttributes; | ||
| use std::str::FromStr; | ||
|
|
||
| #[test] | ||
| fn test_payload_id_parity_op_geth() { |
There was a problem hiding this comment.
these are great though, so please open this as a separate one.
Comment on lines
329
to
+343
| /// Version 1 | ||
| V1, | ||
| V1 = 1, | ||
| /// Version 2 | ||
| /// | ||
| /// Added in the Shanghai hardfork. | ||
| V2, | ||
| V2 = 2, | ||
| /// Version 3 | ||
| /// | ||
| /// Added in the Cancun hardfork. | ||
| V3, | ||
| #[default] | ||
| V3 = 3, | ||
| /// Version 4 | ||
| /// | ||
| /// Added in the Prague hardfork. | ||
| V4, | ||
| V4 = 4, |
There was a problem hiding this comment.
yep we can solve this like this
Sounds good, @mattsse Just reverted the changes related to the payload id |
0xOsiris
requested review from
Rjected,
emhane,
rkrasiuk,
fgimenez and
onbjerg
as code owners
0xOsiris
changed the title
BeaconEngineMessage FCU
mattsse
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
lgtm,
next pr would be, adding the version as additional to
reth/crates/payload/primitives/src/traits.rs
Lines 85 to 88 in 1b0f625
then we can finally get the other pr over the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #12071.
Trying to get this over the finish line. Debating whether
Option<EngineApiMessageVersion>would be more appropriate as there are some places where we have no access to theEngineApiMessageVersionwithout changing other interfaces, and the version is only relevant when starting a build process on Optimism.I have defaulted to
EngineApiMessageVersion::V3in these places, but happy to change. Open to any feedback on the approach