feat(discv4): neighbors packet logging

[khayss]

This is a draft PR.

I have gone through the code base and discovered where the Neighbours packet is received.

I believe it is in here:
https://github.com/paradigmxyz/reth/blob/bea6e278dfdb052ce7bbcec5d42349221aa04b84/crates/net/discv4/src/lib.rs#L1770C28-L1773C30

Based on the current structure of the match block the packet is received, I added the implementation of the trace logs in the on_neighbours method definition of the Discv4Service impl block.
I also added a dependency in the misc section of discv4, this is the itertools package which allows for nice formatting of Vec items.

The code compiled and I ran tests which all passed.

I'd like to get reviews and also help on how I can test to see if the logs are emitted.

Tests

All tests passed.

[onbjerg]

Converted the PR to a draft, you can do that when opening it, or on the right if you already have the PR open under "Reviewers" (it will say something like "Convert to draft")

I also changed the PR title, we try to just use feat:/fix:/test:/perf:/chore: and so on :)

Generally, the PR looks good! Just some minor formatting nits. Thanks for taking this on.

For testing, you can try just running the neighbors test and adding --nocapture to the test command and setting RUST_LOG=discv4=trace, e.g. RUST_LOG=discv4=trace cargo test -p reth-discv4 neighbors_max_nodes -- --nocapture

[khayss]

I have made all the changes as specified above.

Also ran the test with the log level set to TRACE and confirmed the trace log is emitted when neighbor peers are received.

Kindly review and point out any corrections where necessary. Thanks

[mattsse]

this is good, but please remove all additional ; :)

and use nightly formatting cargo +nightly fmt

[onbjerg]

ping @khayss, could you remove the extra semicolons? otherwise this looks good to me:)

addressed

[onbjerg]

Merge activity

• Oct 29, 5:24 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).