headers(part 3) feat: implement Linear downloader #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gakonst
commented
Oct 24, 2022
•
gakonst
commented
- Ports the Linear downloader from wip: feat(sync): headers stage #58
gakonst
changed the title
gakonst
changed the title
Codecov Report
@@ Coverage Diff @@
## gakonst/downloader-test-utils #119 +/- ##
=================================================================
+ Coverage 68.49% 70.43% +1.93%
=================================================================
Files 132 134 +2
Lines 8904 9190 +286
=================================================================
+ Hits 6099 6473 +374
+ Misses 2805 2717 -88
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gakonst
force-pushed
the
gakonst/downloader-test-utils
branch
from
bd27baf to
c19a425
Compare
gakonst
force-pushed
the
gakonst/linear-downloader
branch
from
94718a6 to
2b0f8a1
Compare
mattsse
requested changes
Oct 24, 2022
…#120) * put client & consensus behind arc and return headers in rev * cleanup
rkrasiuk
added a commit
that referenced
this pull request
Oct 24, 2022
* feat(interfaces): implement header client traits * feat: add downloader trait implementer * feat: use explicit error type instead of ok(false) * feat: add constructor to HeaderLocked * test: scaffold mock consensus, downloader and headersclient helpers * test: implement test consensus * test: implement test headers client * refactor: cleanup download headers * chore: fix lint * s/test_utils/test_helpers * headers(part 3) feat: implement Linear downloader (#119) * feat: add headers downloaders crate * feat: more scaffolding * interfaces: generalize retryable erros * feat: implement linear downloader * fix linear downloader tests & add builder * extend & reverse * feat: linear downloader generics behind arc and reversed return order (#120) * put client & consensus behind arc and return headers in rev * cleanup Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com> * extract test_utils * cargo fmt Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
yutianwu
pushed a commit
to yutianwu/reth
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.