Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rpc): small refactor in trace_filter #11894

Merged
merged 1 commit into from
Oct 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions crates/rpc/rpc/src/trace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -314,13 +314,15 @@ where
// add reward traces for all blocks
for block in &blocks {
if let Some(base_block_reward) = self.calculate_base_block_reward(&block.header)? {
let mut traces = self.extract_reward_traces(
&block.header,
&block.body.ommers,
base_block_reward,
all_traces.extend(
self.extract_reward_traces(
&block.header,
&block.body.ommers,
base_block_reward,
)
.into_iter()
.filter(|trace| matcher.matches(&trace.trace)),
);
traces.retain(|trace| matcher.matches(&trace.trace));
all_traces.extend(traces);
} else {
// no block reward, means we're past the Paris hardfork and don't expect any rewards
// because the blocks in ascending order
Expand Down
Loading