feat: switch to composable executor for Ethereum #11838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-enhancement
fgimenez
force-pushed
the
fgimenez/switch-to-composable-executors-eth
branch
3 times, most recently
from
9bd8a71
to
2f4073b
Compare
fgimenez
requested review from
onbjerg,
rkrasiuk,
shekhirin,
mattsse,
Rjected,
emhane and
gakonst
as code owners
Rjected
approved these changes
Oct 18, 2024
|
Let's wait until #11865 is merged to merge this, marking this as blocked for now |
Rjected
added
the
S-blocked
onbjerg
removed
the
S-blocked
mattsse
approved these changes
Oct 19, 2024
fgimenez
force-pushed
the
fgimenez/switch-to-composable-executors-eth
branch
from
cf15ec5
to
7a2a1ee
Compare
fgimenez
force-pushed
the
fgimenez/switch-to-composable-executors-eth
branch
from
7a2a1ee
to
c51d22b
Compare
This was referenced Oct 21, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11274
reth_evm_ethereum::executeand renamesreth_evm_ethereum::strategy->reth_evm_ethereum::executeEthExecutorProviderthat offers the same API as the old provider type to minimize the impact of the change.BasicBlockExecutorProviderandEthExecutionStrategyFactorywhere needed.Successful executions of hive https://github.com/paradigmxyz/reth/actions/runs/11388193195 and kurtosis https://github.com/paradigmxyz/reth/actions/runs/11388196289