Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always poll new pool imports #11675

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix: always poll new pool imports #11675

merged 1 commit into from
Oct 12, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Oct 12, 2024

When we push to pool_imports the import future is never polled thus we only actually import transaction once the TransactionsManager is polled next time which might take a while

Solution is to poll pool_imports after all actions which might result in new futures being pushed to it

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is totally right, the flow here is

incoming messages -> followup work: pool imports

so we must poll them, otherwise the task is only polled again when a new tx comes in which makes total sense now

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Oct 12, 2024
@mattsse mattsse added this pull request to the merge queue Oct 12, 2024
Merged via the queue into main with commit 75dda1c Oct 12, 2024
40 checks passed
@mattsse mattsse deleted the klkvr/fix-imports-polling branch October 12, 2024 04:40
vandenbogart pushed a commit to testmachine-ai/reth that referenced this pull request Oct 14, 2024
reymom pushed a commit to reymom/reth that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants