Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist finalized block #11623

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: persist finalized block #11623

merged 1 commit into from
Oct 10, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 10, 2024

we use this in legacy engine but never ported this to the new design, we need this specifically for op restarts because op-node requests the finalized block on launch.

possibly related #11512 (comment)

@mattsse mattsse requested a review from onbjerg October 10, 2024 00:33
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-op-reth Related to Optimism and op-reth labels Oct 10, 2024
@mattsse mattsse added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 2b97779 Oct 10, 2024
38 checks passed
@mattsse mattsse deleted the matt/persist-finalized-block branch October 10, 2024 01:16
@mattsse mattsse mentioned this pull request Oct 10, 2024
vandenbogart pushed a commit to testmachine-ai/reth that referenced this pull request Oct 14, 2024
reymom pushed a commit to reymom/reth that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants