Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(provider): dont recover sender from BlockState transaction on transaction_sender #11424

Merged
merged 1 commit into from
Oct 2, 2024
Merged

chore(provider): dont recover sender from BlockState transaction on transaction_sender #11424

merged 1 commit into from
Oct 2, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Oct 2, 2024

ExecutedBlock already has all senders

@joshieDo joshieDo added the C-debt Refactor of code section that is hard to understand or maintain label Oct 2, 2024
fgimenez
fgimenez approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@joshieDo joshieDo added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 2ca8231 Oct 2, 2024
36 checks passed
@joshieDo joshieDo deleted the joshie/sender branch October 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@mattsse mattsse Awaiting requested review from mattsse

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @fgimenez