Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stages): call post execute/unwind commit hooks #11413

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(stages): call post execute/unwind commit hooks #11413

merged 1 commit into from
Oct 2, 2024

Conversation

shekhirin
Copy link
Collaborator

No description provided.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-staged-sync Related to staged sync (pipelines and stages) labels Oct 2, 2024
@shekhirin shekhirin marked this pull request as ready for review October 2, 2024 10:07
mattsse
mattsse approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, luckily we don't use this for critical ops

@shekhirin shekhirin added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 82cc96d Oct 2, 2024
36 checks passed
@shekhirin shekhirin deleted the alexey/pipeline-post-commit-call branch October 2, 2024 10:37
@shekhirin shekhirin mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @mattsse @joshieDo