Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trie): bincode compatibility for trie updates #11409

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat(trie): bincode compatibility for trie updates #11409

merged 2 commits into from
Oct 2, 2024

Conversation

shekhirin
Copy link
Collaborator

Closes #11370

@shekhirin shekhirin added C-enhancement New feature or request A-trie Related to Merkle Patricia Trie implementation labels Oct 2, 2024
@shekhirin shekhirin marked this pull request as ready for review October 2, 2024 09:30
mattsse
mattsse approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic nit

crates/trie/trie/src/updates.rs Show resolved Hide resolved
@shekhirin shekhirin added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 4491b0d Oct 2, 2024
36 checks passed
@shekhirin shekhirin deleted the alexey/trie-updates-serde-bincode-compat branch October 2, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compact binary serde for TrieUpdates
2 participants
@shekhirin @mattsse