Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Makefile): separate features by spaces only #11393

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore(Makefile): separate features by spaces only #11393

merged 1 commit into from
Oct 1, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 1, 2024

I was seeing:

	--features "optimism,jemalloc asm-keccak min-debug-logs" \

in CI, separating by spaces is aesthetically better

@Rjected Rjected added C-enhancement New feature or request A-cli Related to the reth CLI A-ci Related to github workflows or other build and lint tools labels Oct 1, 2024
@Rjected Rjected requested a review from gakonst as a code owner October 1, 2024 19:10
@onbjerg onbjerg added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 7e4b1bf Oct 1, 2024
36 checks passed
@onbjerg onbjerg deleted the dan/separate-features-spaces branch October 1, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @onbjerg @emhane