feat: add get_in_memory_or_storage_by_block to BlockchainProvider2
#11384
Conversation
joshieDo
added
C-enhancement
| let block_state = match id { | ||
| BlockHashOrNumber::Hash(block_hash) => { | ||
| self.canonical_in_memory_state.state_by_hash(block_hash) | ||
| } | ||
| BlockHashOrNumber::Number(block_number) => { | ||
| self.canonical_in_memory_state.state_by_number(block_number) | ||
| } | ||
| }; | ||
|
|
||
| if let Some(block_state) = block_state { | ||
| return fetch_from_block_state(block_state) | ||
| } | ||
| fetch_from_db(self.database_provider_ro()?) | ||
| } |
There was a problem hiding this comment.
This makes me wonder if we should just have a method that does the:
if let Some(block_state) = block_state {
return fetch_from_block_state(block_state)
}
fetch_from_db(self.database_provider_ro()?)
part, and provide by_block_hash or by_block_num methods so we don't have to go from number -> id -> match to number. same for hash -> id -> hash
There was a problem hiding this comment.
i think those conversions should be perf-wise negligible, and it's worth imo having all logic in one single method
not that strongly opinated, if someone else would rather have by_block_hash and by_block_num additions i'll add those cc @mattsse
There was a problem hiding this comment.
yeah I think using the enum type here is fine, because some functions that need this feature accept NumHash themselves
| let block_state = match id { | ||
| BlockHashOrNumber::Hash(block_hash) => { | ||
| self.canonical_in_memory_state.state_by_hash(block_hash) | ||
| } | ||
| BlockHashOrNumber::Number(block_number) => { | ||
| self.canonical_in_memory_state.state_by_number(block_number) | ||
| } | ||
| }; | ||
|
|
||
| if let Some(block_state) = block_state { | ||
| return fetch_from_block_state(block_state) | ||
| } | ||
| fetch_from_db(self.database_provider_ro()?) | ||
| } |
There was a problem hiding this comment.
yeah I think using the enum type here is fine, because some functions that need this feature accept NumHash themselves
BlockchainProvider2::history_by_block_hash