Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: limit tracing logs to debug by default #11377

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore: limit tracing logs to debug by default #11377

merged 1 commit into from
Oct 1, 2024

Conversation

DaniPopes
Copy link
Member

Trace level logs are way too verbose and in most cases just degrade performance.

Does not affect debug builds.

mattsse
mattsse reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we use this for our images, right?
imo trace could be helpful, this now removes them from the binary entirely afaik

mattsse
mattsse approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should actually do this, tracing should only be useful for rigorous debugging and all useful things should be debug!

@DaniPopes DaniPopes added this pull request to the merge queue Oct 1, 2024
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-observability Related to tracing, metrics, logs and other observability tools labels Oct 1, 2024
Merged via the queue into main with commit 707067a Oct 1, 2024
36 checks passed
@DaniPopes DaniPopes deleted the dani/debug-logs branch October 1, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse