chore: rm crate reth-rpc-types

[nkysg]

rm crate reth-rpc-types
do we still need trait ToRpcError, @mattsse

reth/crates/rpc/rpc-types/src/eth/error.rs

Lines 4 to 15 in c2cabca

	#[cfg(feature = "jsonrpsee-types")]
	pub trait ToRpcError: core::error::Error + Send + Sync + 'static {
	/// Converts the error to a JSON-RPC error object.
	fn to_rpc_error(&self) -> jsonrpsee_types::ErrorObject<'static>;
	}
	#[cfg(feature = "jsonrpsee-types")]
	impl ToRpcError for jsonrpsee_types::ErrorObject<'static> {
	fn to_rpc_error(&self) -> jsonrpsee_types::ErrorObject<'static> {
	self.clone()
	}
	}

[mattsse]

I'd like to approach this differently, because this error type is also used as a library error so what you could do instead is move the ToRpcError to reth-rpc-types and retire the rpc-types crate

[nkysg]

I'd like to approach this differently, because this error type is also used as a library error so what you could do instead is move the ToRpcError to reth-rpc-types and retire the rpc-types crate

Actually ToRpcError is in crate reth-rpc-types.

reth/crates/rpc/rpc-types/src/eth/error.rs

Lines 4 to 8 in c2cabca

	#[cfg(feature = "jsonrpsee-types")]
	pub trait ToRpcError: core::error::Error + Send + Sync + 'static {
	/// Converts the error to a JSON-RPC error object.
	fn to_rpc_error(&self) -> jsonrpsee_types::ErrorObject<'static>;
	}

so we don't need to move the ToRpcError to reth-rpc-types.
and ToRpcError trait only use in

reth/crates/rpc/rpc-eth-types/src/simulate.rs

Lines 50 to 54 in c2cabca

	impl ToRpcError for EthSimulateError {
	fn to_rpc_error(&self) -> ErrorObject<'static> {
	rpc_err(self.error_code(), self.to_string(), None)
	}
	}

do you mean move the ToRpcError to crate reth-rpc-eth-types?

Is there an error in my understanding?

[mattsse]

do you mean move the ToRpcError to crate reth-rpc-eth-types?

yes I did -.-

let's move the trait there and we can finally remove the rpc-types crate

[mattsse]

great!