fix: never ban trusted peers #11254
Merged
fix: never ban trusted peers #11254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-bug
emhane
approved these changes
Sep 30, 2024
| @@ -1896,6 +1902,64 @@ mod tests { | |||
| assert!(!peers.peers.contains_key(&peer)); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_fatal_outgoing_connection_error_trusted() { | |||
| let peer = PeerId::random(); | |||
There was a problem hiding this comment.
Suggested change
| let peer = PeerId::random(); | |
| let trusted_peer = PeerId::random(); |
nitpick, helps to follow along a bit better
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11244
on a fatal connection err (which also currently has a bug), we ended up removing trusted peers.
this adds an additional check and only removes the peer from the set if it isn't trusted