Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reth-codec: remove unused derives from alloy compat types #11231

Merged
merged 2 commits into from
Sep 26, 2024
Merged

reth-codec: remove unused derives from alloy compat types #11231

merged 2 commits into from
Sep 26, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 26, 2024 •
edited
Loading

towards #11199

mattsse
mattsse approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, clippy unrelated

@mattsse mattsse merged commit ece0944 into paradigmxyz:main Sep 26, 2024
33 of 35 checks passed
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 26, 2024
@nkysg nkysg deleted the remove_unused_derives branch September 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkysg @mattsse